feat: UX Overhaul#8
Merged
Merged
Conversation
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Copilot started reviewing on behalf of
Lauri "datafox" Heino (melodicore)
May 5, 2026 15:02
View session
Copilot started reviewing on behalf of
Lauri "datafox" Heino (melodicore)
May 5, 2026 16:00
View session
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 37 out of 40 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (2)
java-compiler/src/main/kotlin/dev/elide/maven/compiler/ElideLocator.kt:41
PATHis split using a hard-coded':', which will fail on Windows (where the path separator is';') and can also behave incorrectly when path entries contain:(drive letters). Use the platform path separator (e.g.File.pathSeparatorChar/System.getProperty("path.separator")) when splitting PATH, and keep usingELIDE_EXECUTABLEfor the filename.
java-compiler/src/main/kotlin/dev/elide/maven/compiler/ElideJavacCompiler.kt:83ElideJavacCompileruses a mutable global (companion object executable) to override the binary path. Because the mojos are markedthreadSafeand Maven can run compiles in parallel (multi-module /-T), this introduces a race where one module’s configured executable can affect another module’s compilation. Prefer passing the executable throughCompilerConfiguration(i.e., rely onconfig.executable) or make the override instance-scoped instead of global mutable state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Signed-off-by: melodicore <datafox@datafox.me>
Copilot started reviewing on behalf of
Lauri "datafox" Heino (melodicore)
May 11, 2026 13:16
View session
Signed-off-by: melodicore <datafox@datafox.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<extensions>in Elide Kotlin Maven pluginelide-plexus-compilerstoelide-java-compiler